[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16296 - MarcWeber - in nixpkgs/trunk/pkgs: development/libraries/haskell development/libraries/haskell/bytestring development/libraries/haskell/get-options development/libraries/haskell/ghc-syb development/libraries/haskell/network-bytestring development/libraries/haskell/syb development/misc/bleeding-edge-repos development/tools/haskell development/tools/haskell/hslogger development/tools/haskell/tar misc top-level

[Eelco Dolstra]

Hi,

Marc Weber wrote:

Some comments/questions:

> Added: nixpkgs/trunk/pkgs/development/libraries/haskell/get-options/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/development/libraries/haskell/get-options/default.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/development/libraries/haskell/get-options/default.nix	2009-07-09 22:24:02 UTC (rev 16296)
...
> +  meta = {
> +    description = "simple to use get option library";

Please capitalise the description field.

> Added: nixpkgs/trunk/pkgs/development/libraries/haskell/ghc-syb/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/development/libraries/haskell/ghc-syb/default.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/development/libraries/haskell/ghc-syb/default.nix	2009-07-09 22:24:02 UTC (rev 16296)
> @@ -0,0 +1,12 @@
> +{cabal, syb, sourceByName}:
> +
> +cabal.mkDerivation (self : {
> +  pname = "hlint";
> +  version = "1.4";
> +  name = self.fname;
> +  src = sourceByName "ghc_syb";

What does "sourceByName" do?

> Added: nixpkgs/trunk/pkgs/development/libraries/haskell/network-bytestring/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/development/libraries/haskell/network-bytestring/default.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/development/libraries/haskell/network-bytestring/default.nix	2009-07-09 22:24:02 UTC (rev 16296)
...
> +  meta = {
> +    description = "Source code suggestions";

This description doesn't seem to match the package.

> Modified: nixpkgs/trunk/pkgs/development/misc/bleeding-edge-repos/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/development/misc/bleeding-edge-repos/default.nix	2009-07-09 22:23:59 UTC (rev 16295)
> +++ nixpkgs/trunk/pkgs/development/misc/bleeding-edge-repos/default.nix	2009-07-09 22:24:02 UTC (rev 16296)

I've never quite understood the rationale for bleeding-edge-repos.  Can you shed
some light on this?

Also, how does "pkgs/development/misc/bleeding-edge-repos/default.nix" relate to
"pkgs/misc/bleeding-edge-fetch-infos.nix"?  They seem to have some overlap, e.g.

> +      getOptions = { type="darcs"; url="http://repetae.net/john/repos/GetOptions"; groups=""; };

and

> +  getOptions = args: with args; fetchurl { # Thu Jul  9 23:31:53 CEST 2009
> +    url = "http://mawercer.de/~nix/repos/getOptions-nrmtag1.tar.gz";
> +    sha256 = "5ec39b43a58a507ed3652bc53d57d9b785a6fbb72a8824b951590e076c704589";
>    };

(And what are these "infos" anyway?)

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/