[Nix-dev] Ordering of ‘checkPhase’ and ‘installPhase’

[Ludovic Courtès]

Hi Rob,

Rob Vermaas <rob.vermaas at gmail.com> writes:

> Author: rob
> Date: 2009-11-26 06:52:13 +0000 (Thu, 26 Nov 2009)
> New Revision: 18637
>
> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=18637&view=rev
>
> Modified:
>    nixpkgs/trunk/pkgs/build-support/release/nix-build.nix
>
> Log:
> revert change from ludo rev. 18634. for now this order is needed for
> the stratego packages in the buildfarm, and the order should matter as
> normally nothing gets built in check phase that is needed for install
> phase

This is Plain Wrong(TM).  The ‘check’ makefile target must *not* depend
on the installed software (there’s ‘installcheck’ for that).  In
particular, it’s very important for ‘check’ to test the software that’s
just been built in $(builddir), not the one that’s installed.

If Stratego’s build system relies on this bogus behavior, it should
change the order of phases in its own ‘release.nix’.  Another option is
for Stratego to have ‘check’ do nothing and do the actual tests in
‘installcheck’.

Thanks,
Ludo’.