[Nix-dev] nixos-rebuild --show-trace should be default

Marc Weber marco-oweber at gmx.de
Thu Jan 7 10:03:20 CET 2010


Does someone mind my comitting this patch?

it enables --show-trace by default when running nixos-rebuild.
If nobody minds I'll commit this tonight.

Marc Weber


>From 33c06192bb667685bda874a16237e79af4869299 Mon Sep 17 00:00:00 2001
From: Marc Weber <marco-oweber at gmx.de>
Date: Thu, 7 Jan 2010 09:17:48 +0100
Subject: [PATCH] enable --show-trace when running nixos-rebuild by default.
 I always keep adding it. If there is no error there is no additional output.
 If there is an error you want to see the trace

---
 modules/installer/tools/nixos-rebuild.sh |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/modules/installer/tools/nixos-rebuild.sh b/modules/installer/tools/nixos-rebuild.sh
index d799ee6..77469e6 100644
--- a/modules/installer/tools/nixos-rebuild.sh
+++ b/modules/installer/tools/nixos-rebuild.sh
@@ -36,10 +36,6 @@ Options:
 
   --fast                 same as --no-pull --no-build-nix --show-trace
 
-Various nix-build options are also accepted, in particular:
-
-  --show-trace           show a detailed stack trace for evaluation errors
- 
 Environment variables affecting nixos-rebuild:
 
   \$NIXOS                 path to the NixOS source tree
@@ -51,7 +47,10 @@ EOF
 
 
 # Parse the command line.
-extraBuildFlags=
+
+# if there is no error --show-trace doesn't harm - if there is an error you want it.
+# so enable --show-trace by default
+extraBuildFlags="--show-trace"
 action=
 pullManifest=1
 buildNix=1
-- 
1.6.5.6



More information about the nix-dev mailing list