[Nix-dev] Re: [PATCH 1/2] Added classads, gsoap, libvirt

[Ludovic Courtès]

Hi Nate,

Just a bit of nitpicking:

Nate Griswold <griswold at cs.wisc.edu> writes:

> +    description = "The Classified Advertisements library provides a generic means for matching resources.";

The ‘description’ field should not be a sentence but rather a small
phrase.  Make sure to read the “Meta-attributes” and “Coding
conventions” chapters of the Nixpkgs manual:

  http://hydra.nixos.org/job/nixpkgs/trunk/tarball/latest/download-by-type/doc/manual

> --- a/pkgs/top-level/all-packages.nix
> +++ b/pkgs/top-level/all-packages.nix
> @@ -8734,6 +8734,18 @@ let
>      inherit (stdenv) mkDerivation;
>    };
>  
> +  classads = import ../development/libraries/classads {
> +    inherit fetchurl stdenv;
> +  };

Normally these should be sorted alphabetically and under the right
header (search for ‘###’).

Thanks,
Ludo’.