[Nix-dev] [Nix-commits] SVN commit: nix - r29820 - nixpkgs/trunk/pkgs/top-level

[Eelco Dolstra]

Hi,

On 10/13/2011 03:04 PM, Florian Friesdorf wrote:

> Author: chaoflow

> +  # Please keep in sync with linux_3_0_powertop, except for extraConfig
>    linux_3_0 = makeOverridable (import ../os-specific/linux/kernel/linux-3.0.nix) {
...
> +  # Please keep in sync with linux_3_0, except for extraConfig
> +  linux_3_0_powertop = makeOverridable (import ../os-specific/linux/kernel/linux-3.0.nix) {
> +    inherit fetchurl stdenv perl mktemp module_init_tools ubootChooser;
> +    extraConfig = ''
> +        CPU_FREQ_GOV_ONDEMAND y

Assuming that there is no significant runtime cost, why not just put this in the
default kernel?  It's not a good idea to have a separate kernel for every little
feature.  We have too many kernels already (creating a potential maintenance
problem).

BTW, as far as I can tell from my 2.6.35 kernel, some of these options are
already enabled (e.g., HIGH_RES_TIMERS, HPET_TIMER, NO_HZ).

CPU_FREQ_GOV_ONDEMAND should be "m" instead of "y".

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/