[Nix-dev] remarks regarding modules/services/x11/display-managers/default.nix

[Arie Middelkoop]

 > modules/services/x11/display-managers/default.nix

 > ${optionalString (!cfg.displayManager.job.logsXsession) ...
The "!" should be removed, because the session now gets logged if the 
attribute is "false". Since the default value is "false", the logging is 
thus by default on (by itself not bad).

 > job = mkOption {
 >  default = {};
 >  type = types.uniq types.optionSet;

Because of the "types.uniq", it is not possible to change the 
logsXsession attribute in configuration.nix as the jobs-options are 
partially set by the expression of the display manager that is enabled.

I have a non-obstrusive patch for both issues, but as I don't know if 
the above was introduced on purpose or just happens to be the case, I 
don't know whether I should commit it.

Arie