[Nix-dev] [Nix-commits] SVN commit: nix - r32912 - nixos/trunk/modules/tasks

[Eelco Dolstra]

Hi,

On 08/03/12 22:07, Lluís Batlle wrote:

> +  fsPostDeviceCommands = optionalString usingBtrfsStage1 ''
> +    btrfs device scan
> +  '';

Shouldn't the calls to "btrfs device scan" be done from udev (similar to what
LVM does)?

>              echo "mounting filesystems..."
>              export PATH=${config.system.sbin.mount}/bin:${makeSearchPath "sbin" ([pkgs.utillinux] ++ fsPackages)}:$PATH
> -            ${optionalString needsBtrfsProgs "${pkgs.btrfsProgs}/bin/btrfs device scan"}
> +            ${optionalString usingBtrfs "${pkgs.btrfsProgs}/bin/btrfs device scan"}

This won't work properly because there is no guarantee that the underlying
devices will exist by the time this command runs.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/