[Nix-dev] [Nix-commits] SVN commit: nix - r32999 - nixos/trunk/modules/system/boot

[Lluís Batlle i Rossell]

On Sun, Mar 11, 2012 at 11:36:02PM +0100, Eelco Dolstra wrote:
> On 11/03/12 23:31, Lluís Batlle i Rossell wrote:
> > On Sun, Mar 11, 2012 at 11:29:44PM +0100, Eelco Dolstra wrote:
> >> On 11/03/12 22:50, Lluís Batlle wrote:
> >>
> >>>    bootStage2 = pkgs.substituteAll {
> >>>      src = ./stage-2-init.sh;
> >>> +    shell = "${pkgs.bashInteractive}/bin/bash";
> >>
> >> The stage 2 shell should not be interactive.  The debug shell is a separate
> >> thing from the shell executing the stage 2 script.
> > 
> > I did not think it was bad to use the interactive bash to execute the init
> > script, and then the debug shell would simply call @shell at . We can have two bash
> > references in it, if you want.
> 
> Actually, if you want an interactive bash from the debug shell, you can just
> type "bash" on the command line.  No need to over-engineer something that very
> few people should ever have a need to touch.  (The "setsid" is good, though, if
> it makes Ctrl-C work.)

Yes, it makes ctrl-c work.

I'd personally prefer (and expect) to have "up/down/left/right" arrows working
in a shell meant to be interactive, instead of having to know that if I type
"bash" I'll get interactive editing with history.

So I'll just commit the overengineering with a non-interactive bash running the
script, and if you prefer the non-interactive bash prompt for the interactive
shell, either you or me can take all back.

Regards,
Lluís.