[Nix-dev] SVN commit r32596

[Corey O'Connor]

On Wed, Mar 14, 2012 at 2:28 PM, Yury G.  Kudryashov
<urkud.urkud at gmail.com> wrote:
> pkgs.libgnome_keyring, not pkgs.gnome.libgnome_keyring. Passed to evince.
> Let's see if it helps.

Ah!
Passing pkgs.libgnome_keyring works great! Looks like that is a solid
patch. I'll submit just that in a bit. The patch will not include the
libxml2/python changes.

>> *shrug* I like the free hosting of github and the pull request
>> workflow is smooth. Never used gitorious.
>> So long as "email patches to mailing list" is not the plan for the
>> future. ;-) Half the patches appear to get lost, ignored, or are just
>> never actually committed to svn.
> I'll try to install reviewboard (works well with svn).

Reviewboard looks nice. The "submit patch" workflow looks good.

Cheers,
Corey