[Nix-dev] [Nix-commits] SVN commit: nix - r33140 - in nixos/trunk: lib modules/installer/cd-dvd modules/installer/efi-boot-stub

[Eelco Dolstra]

Hi,

On 16/03/12 06:37, Shea Levy wrote:

> -  boot.kernelPackages = pkgs.linuxPackages_3_2;
> +  boot.kernelPackages = pkgs.linuxPackages_3_3;

Given that Linux 3.3 hasn't even been released yet, I don't think this is a good
idea.  The "new-kernel" ISO shouldn't be *that* bleeding edge :-)

(Actually, it's time to bump the default kernel from 2.6.35 to something newer.
 Not sure what the best "long-term stability" kernel would be though.)

> +  isoImage.makeEfiBootable = true;

Does making an ISO EFI-bootable have any effect on non-EFI systems?

> +      description = ''
> +        Whether the ISO image should be an efi-bootable volume

There should be a period at the end of this sentence.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/