[Nix-dev] [Nix-commits] SVN commit: nix - r33139 - nixos/trunk/modules/system/activation

[Eelco Dolstra]

On 16/03/12 12:33, Shea Levy wrote:

>>> Log:
>>> Allow multiple definitions of boot.loader.kernelFile as long as they are all the same
>> ...
>>> +      merge = kernelFiles:
>>> +        builtins.head (map (f: assert f == builtins.head kernelFiles; f)
>>> +          kernelFiles);
>> Wouldn't it be better to just declare the option as having type "uniq"?  That
>> way there can be only one definition (of the highest priority).
> 
> Does this mean that only one definition is allowed at all, or that NixOS 
> has some way of determining which definition to use in case multiple are 
> given?

That there is only one allowed (so the option should be called "kernelFile"
instead of "kernelFiles").  Modules can give a priority to override definitions
in other modules, e.g.

  kernelFile = mkOverride 50 "/foo/bar";

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/