[Nix-dev] [Nix-commits] [NixOS/nixpkgs] 5626c5: replace-dependency: don't break nixpkgs for people...

[Eelco Dolstra]

Hi,

On 12/01/13 15:48, Shea Levy wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/NixOS/nixpkgs
>   Commit: 5626c5cdfb6de664881eb8b79dd54a8f4ca19b8f
>       https://github.com/NixOS/nixpkgs/commit/5626c5cdfb6de664881eb8b79dd54a8f4ca19b8f
>   Author: Shea Levy <shea at shealevy.com>
>   Date:   2013-01-12 (Sat, 12 Jan 2013)
> 
>   Changed paths:
>     M pkgs/top-level/all-packages.nix
> 
>   Log Message:
>   -----------
>   replace-dependency: don't break nixpkgs for people living in the stone age

Urgh, please rename this to replaceDependency.  (Likewise for every other
variable pkgs/build-support/replace-dependency.nix.)  Function/variable names in
Nix use lower camel case, not dashes.

Also, why is this function included in the all-packages.nix attribute set?  It's
not a package, so there's no need to include it there.  Putting it in lib seems
better.

-- 
Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/