[Nix-dev] Commit access request (Again: Why don't thesepeoplehave commit access)

Michael Raskin 7c6f434c at mail.ru
Mon Jan 19 23:06:52 CET 2015


>> >> Nevertheless I want to go though my packages and do version bumps
>> >> in the near future, and I believe this (and things like grammar
>> >> fixes) is kind of patches that should be applied more directly than
>> >> usual, to bother less contributors so that they can focus on
>> >> more non-trivial things.
>> >
>> >What keeps you from having a "version-bumping" branch where all your
>> >patches are in and open just one PR for all the patches at once?
>> 
>> Pity towards me, who will read a PR of unrelated changes and wonder what
>> saced animal have I crossed in my previous life?
>
>Have you ever looked how kernel maintainers do their work? For example
>greg-kh with his staging-next branch? Do you think someone actually
>goes through these patches except gregkh himself? ;-)

Unless someone glances briefly at each line, we should not use people as
a "git push" replacement.

If there are many unrelated changes, that means you don't create
a mental model as you read, but you still have to review the PR at once
as we lack better review tools for such cases.





More information about the nix-dev mailing list