[Nix-dev] Re: [Nix-commits] SVN commit: nix - 14893 - viric - in nixpkgs/trunk/pkgs: applications/graphics applications/graphics/panotools top-level

[Ludovic Courtès]

Saluton,

Llus Batlle <viriketo at gmail.com> writes:

> +  src = fetchsvn {
> +    url = https://panotools.svn.sourceforge.net/svnroot/panotools/trunk/libpano;
> +    rev = 955;
> +  };

Two remarks:

  1. It'd be better to provide `sha256', for improved reproducibility.

  2. Why not use a release version?  Often, upstream developers know
     better than we do what's "releasable".

> +  meta = {
> +    homepage = http://panotools.sourceforge.net/;
> +    description = "Panorama Tools";
> +    license = "GPL";
> +  };

Please use "GPLv2+", or "GPLv3+", etc.

Also, the description is a bit terse and `longDescription' is missing.

Thanks,
Ludo'.