[Nix-dev] Re: [Nix-commits] SVN commit: nix - 19267 - MarcWeber - nixos/trunk/modules/services/web-servers/apache-httpd

[Eelco Dolstra]

Hi,

Marc Weber wrote:

> +        description = ''
> +          You can override php default settings by using a customized php.ini file.
> +          Have a look at teh comment above this description to see how to enable Xdebug

There are several typos in this description ("teh", no period at the end of the
last sentence, etc.).  Also, the description doesn't actually say what this
option does: it says that you *can* override the PHP settings, but not that this
option does that.

Also, the description ends up in the manual, so referring people to somewhere
"above this description" is not helpful.  Maybe you can put this in an "example"
attribute.

> -           PHPRC = pkgs.writeText "php.ini"

Why is "PHPRC" capitalized?

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/