[Nix-dev] Re: [Nix-commits] SVN commit: nix - 19267 - MarcWeber - nixos/trunk/modules/services/web-servers/apache-httpd

[Marc Weber]

> There are several typos in this description ("teh", no period at the end of the
> last sentence, etc.).  Also, the description doesn't actually say what this
> option does: it says that you *can* override the PHP settings, but not that this
> option does that.
Why else should it be called phpIni then? I don't want to read "this
option sets" in all descriptions..

> 
> Also, the description ends up in the manual, so referring people to somewhere
> "above this description" is not helpful.  Maybe you can put this in an "example"
> attribute.

I was about adding "No time to think about proper qouting" I should have
done so :)

Have a look at the "Example code (copy & paste):" message which should
make it clear how to use such an option. That was one reason why I
hesitated adding the exapmle. "no time" was the much more pressing
cause.

> > -           PHPRC = pkgs.writeText "php.ini"
> 
> Why is "PHPRC" capitalized?

It's funny that you ask this because it looks like you added it in
-r18777:

    * Allow Mediawiki (and other PHP applications) to send email through
      the `sendmail' command (i.e. ssmtp).  This is hacky - there should
      be some global config value that specifies the path to sendmail,
      which the ssmtp module and others can then set.


I don't know. PHPRC is exorted as env var in the apache httpd job. It
works. I didn't explore and I'm not going to do so.

I hope you like the new description more than the old one.

I'll send the patches to this mailing list until Eelco Dolstra told me
how to reproduce the Apache configuration syntax error which made him
revert the previous patch.

Marc Weber