[Nix-dev] Binary patches, again

[Eelco Dolstra]

Hi,

On 04/02/2010 05:55 PM, Lluís Batlle wrote:

> As 'urkud' in irc pointed that there are still side effects in the
> store paths (nixbld1, nixbld2, ... strings in the resulting output,
> impurities), we could use the database in nix-store for hashes of the
> output store paths. If they match, use the patch. If not, then don't.
> I guess that database exists and it is used by nix-store to check if
> output paths have been modified.
> 
> Looking at a manifest, I see:
...
> Is the BaseHash already what I am talking about?

Yes.  Download-using-manifests rejects a patch if the content hash (i.e.
BaseHash) of the store path doesn't match the one in the manifest.

> If it is, why isn't hydra creating patches?

Mainly because we haven't got around to implementing it :-)  I think Rob is
going to work on it.  Another worry is the load that this would put on the server.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/